Issue #26: Support handling configuration files without read permissions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 13, 2019 09:33
This was referenced Nov 15, 2019
neongreen
reviewed
Nov 22, 2019
test/Fencer/Rules/Test.hs
Outdated
| ( tests | ||
| , writeAndLoadRules | ||
| -- example values | ||
| , domain1Text |
There was a problem hiding this comment.
Let's not have different *.Test files depending on each other.
Let's also not have something like domain1Text in an export list, the name does not describe the semantics.
You can have a module called RuleExamples or something and reexport rules from there.
There was a problem hiding this comment.
I created a separate module Fencer.Rules.Test.Examples with these example values and renamed them to better suite what they represent.
effectfully
approved these changes
Nov 22, 2019
added 9 commits
November 22, 2019 17:53
|
@neongreen, I'll proceed with merging this PR. In case there are still things you would like to see changed, please let me know in any of the PRs depending on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following remark from issue #26: "When lyft/ratelimit can't read a file (e.g.
chmod 0-ed), other files are loaded correctly and it responds to requests with OK." Fencer now matches the behavior.Also see a discussion in an issue #26 comment.