Issue #26: No configuration directory #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 13, 2019 09:33
… an unreadable configuration file
added 4 commits
November 15, 2019 15:49
effectfully
reviewed
Nov 25, 2019
mdimjasevic
pushed a commit
that referenced
this pull request
Nov 26, 2019
mdimjasevic
pushed a commit
that referenced
this pull request
Nov 26, 2019
…ltiple requests per @effectfully's suggestion
effectfully
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following remark from issue #26: When lyft/ratelimit doesn't find the dir symlink, it responds to requests with OK.
Fencer behaves the same way and a server test was added to confirm this behavior.
Please review PR #102 first because it and this PR both depend on the
mdimjasevic/26-cant-read-filebranch.