Issue #26: Check behavior in presence of duplicate rules #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an unreadable configuration file
* Migrate to DockerHub * TEST COMMIT WILL REVERT LATER * Fix the token * Use env vars * Push only when on master
…est for loadRulesFromDirectory
…cer into mdimjasevic/26-duplicate-domain
…encer into mdimjasevic/26-duplicate-rules
mdimjasevic
changed the title
added 9 commits
November 15, 2019 07:49
…cer into mdimjasevic/26-duplicate-domain
…cer into mdimjasevic/26-duplicate-domain
added 2 commits
November 21, 2019 09:51
…cer into mdimjasevic/26-duplicate-domain
…encer into mdimjasevic/26-duplicate-rules
effectfully
approved these changes
Nov 22, 2019
added 15 commits
November 22, 2019 17:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch answers the following question from issue #26: "What happens when a domain contains duplicate rules?"
When Ratelimit is run on a configuration that has a domain key repeated, it logs an error message such as:
It loads no definitions and consequently responds with the following when it receives a request:
This PR updates Fencer to match this behavior.
Note that this PR started off from the
mdimjasevic/26-duplicate-domainbranch, which has a PR #103, which in turn depends on a PR #102. Therefore, please review the dependency chain first.