Issue #26: No configuration found #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 13, 2019 09:33
… an unreadable configuration file
added 4 commits
November 21, 2019 07:50
…cer into mdimjasevic/26-no-config
…cer into mdimjasevic/26-no-config
effectfully
reviewed
Nov 26, 2019
effectfully
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the following remark from issue #26: When lyft/ratelimit finds no configs in the dir, it responds to requests with OK.
Fencer does the same. A server test was added to confirm this.
Note: The PR is based on the
mdimjasevic/26-cant-read-filebranch, even though I believe the final result does not need any changes from it. The mentioned branch is for PR #102.