Issue #26: Handling duplicate domains #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an unreadable configuration file
* Migrate to DockerHub * TEST COMMIT WILL REVERT LATER * Fix the token * Use env vars * Push only when on master
…est for loadRulesFromDirectory
…cer into mdimjasevic/26-duplicate-domain
added 8 commits
November 15, 2019 07:49
…cer into mdimjasevic/26-duplicate-domain
…cer into mdimjasevic/26-duplicate-domain
…cer into mdimjasevic/26-duplicate-domain
effectfully
approved these changes
Nov 22, 2019
added 6 commits
November 22, 2019 17:53
added 6 commits
November 25, 2019 11:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch answers the following question from issue #26: "What happens when configuration contains duplicate domains?" Ratelimit errors with a log message such as:
When a request is submitted to it, it responds with:
This patch updates Fencer to match the behavior.
Note that I used some functionality from the
mdimjasevic/26-cant-read-filebranch, hence this PR's branch is based on that branch. In other words, please review PR #102 first.