Issue #26: Faulty reloading parsing #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 13, 2019 09:33
… an unreadable configuration file
mdimjasevic
changed the title
added 6 commits
November 21, 2019 07:50
…cer into mdimjasevic/26-faulty-reloading-parsing
neongreen
changed the title
effectfully
reviewed
Nov 22, 2019
effectfully
reviewed
Nov 26, 2019
test/Fencer/Rules/Test.hs
Outdated
| assertBool "unexpected definitions" | ||
| (((==) `on` show) | ||
| (sortOn domainDefinitionId <$> result) | ||
| (Right $ sortOn domainDefinitionId definitions)) |
There was a problem hiding this comment.
It's a little hard to read these lines. I'd probably use do-notation, but even just
assertBool "unexpected definitions" $
((==) `on` show)
(sortOn domainDefinitionId <$> result)
(Right $ sortOn domainDefinitionId definitions)is already more readable.
There was a problem hiding this comment.
That's a fair point! I addressed it with lets in an upcoming commit.
There was a problem hiding this comment.
@effectfully: Any remaining issues to be addressed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following question from issue #26 : What happens if at reloading, one rule (out of several) in one domain (out of several) can't be parsed?
Ratelimit keeps the original rules and this PR adds a test to Fencer to confirm it matches the behavior.
I have two remarks:
Fencer.Main.mainwould have to be reimplemented. Given that there is no much benefit in such a server test, I added a rule reloading test only.mdimjasevic/26-cant-read-filebranch. Therefore, please review PR Issue #26: Support handling configuration files without read permissions #102 first.