-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create initial version of notebooks #862
Create initial version of notebooks #862
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Updated instructions on notebook execution and dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreedhar-guda, great job - just minor comments and the main thing for me is the ReadMe really needs to be updated before merging this, otherwise there is no connection to what to do with the content for the user.
e2e_samples/fabric_dataops_sample/config/application.cfg.template
Outdated
Show resolved
Hide resolved
e2e_samples/fabric_dataops_sample/images/config-update-workflow.png
Outdated
Show resolved
Hide resolved
e2e_samples/fabric_dataops_sample/src/notebooks/nb-010-setup.ipynb
Outdated
Show resolved
Hide resolved
e2e_samples/fabric_dataops_sample/src/notebooks/nb-010-setup.ipynb
Outdated
Show resolved
Hide resolved
trace_exporter = AzureMonitorTraceExporter(connection_string=self.conn_string) | ||
span_processor = BatchSpanProcessor(trace_exporter) | ||
tracer_provider.add_span_processor(span_processor) | ||
tracer = trace.get_tracer(tracer_name, tracer_provider=tracer_provider) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sreedhar-guda, it's tiny thing but let me ask.
Do you have any intention here why not setting tracer_provider
globally like trace.set_tracer_provider(tracer_provider)
.
The reason why I'm asking this is because this code will have a following error (but it's not blocker) during exporting.
ERROR:azure.monitor.opentelemetry.exporter.export.trace._exporter:Failed to derive Resource from Tracer Provider: 'ProxyTracerProvider' object has no attribute 'resource'
(Reference: azure monitor otel github looks globally setting tracer_provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maniSbindra , do you know the above details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried deploying and running notebooks. All looks good.
01543b0
into
feat/e2e-fabric-dataops-sample
Type of PR
Purpose
The changes are to create the first version of the setup book notebook which creates database schemas and tables needed for Parking sensor sample. The changes include:
What it includes:
Note that, the config and OTEL script files are named and in locations (configs and otel script) as per discussion (References #840).
Does this introduce a breaking change? If yes, details on what can break
No
Author pre-publish checklist
Validation steps
Issues Closed or Referenced