fix: side effects optimize panic when remove lib file

[jerrykingxyz]

Summary

1. Remove the Option in SideEffectsOptimizeArtifact value.

-  pub type SideEffectsOptimizeArtifact = UkeyMap<DependencyId, Option<SideEffectsDoOptimize>>
+  pub type SideEffectsOptimizeArtifact = UkeyMap<DependencyId, SideEffectsDoOptimize>;

2. SideEffectsOptimizeArtifact retain the item which target module and deps exist when incremental rebuild.

side_effects_optimize_artifact.retain(|dependency_id, do_optimize| {
      let dep_exist = module_graph
        .connection_by_dependency_id(dependency_id)
        .is_some();
      let target_module_exist = module_graph
        .module_by_identifier(&do_optimize.target_module)
        .is_some();
      dep_exist && target_module_exist
    });

Related links

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	6be67c5
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/68fb5679f811b5000832697e

[Copilot]

Pull Request Overview

This PR fixes a panic that occurs when removing a library file during incremental compilation with side effects optimization enabled. The fix ensures proper handling of missing modules and dependencies in the optimization artifact, preventing the panic while maintaining correct incremental build behavior.

Key changes:

• Modified side effects optimization to validate both dependency and target module existence before processing
• Changed the optimization artifact type to eliminate Option wrapper, simplifying the data structure
• Added comprehensive e2e test case demonstrating the fix for file removal scenarios

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/e2e/playwright.config.ts	Added conditional check to prevent overriding incremental configuration when already defined
tests/e2e/cases/incremental/remove-optimized-module/rspack.config.js	Test configuration enabling incremental caching with side effects optimization
tests/e2e/cases/incremental/remove-optimized-module/package.json	Package configuration marking modules as side effect-free
tests/e2e/cases/incremental/remove-optimized-module/index.test.ts	E2e test verifying no panic occurs when removing optimized modules
tests/e2e/cases/incremental/remove-optimized-module/index.js	Test entry point importing component to be removed
tests/e2e/cases/incremental/remove-optimized-module/comp/index.js	Component barrel export file
tests/e2e/cases/incremental/remove-optimized-module/comp/Button.js	Component module that gets removed during test
crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs	Core fix: validates module existence before processing and refactored artifact collection to use streaming approach
crates/rspack_core/src/module_graph/mod.rs	Reformatted conditional to improve readability
crates/rspack_core/src/exports/target.rs	Changed function visibility from public to private
crates/rspack_core/src/artifacts/side_effects_do_optimize_artifact.rs	Simplified artifact type by removing Option wrapper

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[github-actions]

📦 Binary Size-limit

Comparing 6be67c5 to test: migrate cli tests to rstest (#11989) by 9aoy

🎉 Size decreased by 1.00KB from 47.85MB to 47.85MB (⬇️0.00%)

[codspeed-hq]

CodSpeed Performance Report

Merging #11939 will not alter performance

_{Comparing jerry/sideEffect (6be67c5) with main (941e220)}

Summary

✅ 17 untouched