Skip to content

Commit dc1bedf

Browse files
committed
fix ci
1 parent a88e4ab commit dc1bedf

File tree

2 files changed

+2
-6
lines changed
  • crates/rspack_core/src/utils/iterator_consumer
  • tests/e2e/cases/incremental/remove-optimized-module

2 files changed

+2
-6
lines changed

crates/rspack_core/src/utils/iterator_consumer/rayon.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@ where
1919
type Item = I;
2020
fn consume(self, mut func: impl FnMut(Self::Item)) {
2121
let (tx, rx) = channel::<Self::Item>();
22-
std::thread::scope(|s| {
23-
// move rx to s.spawn, otherwise rx.into_iter will never stop
24-
s.spawn(move || {
22+
rayon::in_place_scope(move |s| {
23+
s.spawn(move |_| {
2524
self.for_each(|item| tx.send(item).expect("should send success"));
2625
});
2726
while let Ok(data) = rx.recv() {

tests/e2e/cases/incremental/remove-optimized-module/index.test.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ test("remove optimized module should not panic", async ({
99
fileAction.deleteFile("comp/Button.js");
1010

1111
const overlay = page.frameLocator("#webpack-dev-server-client-overlay");
12-
await expect(
13-
overlay.getByText("ESModulesLinkingWarning: export 'Button'")
14-
).toBeVisible();
1512
await expect(
1613
overlay.getByText("Module not found: Can't resolve './Button'")
1714
).toBeVisible();

0 commit comments

Comments
 (0)