fix ci

Author: jerrykingxyz

crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs

@@ -6,9 +6,8 @@ use rspack_core::{
   BoxModule, Compilation, CompilationOptimizeDependencies, ConnectionState, DependencyExtraMeta,
   DependencyId, FactoryMeta, Logger, MaybeDynamicTargetExportInfo, ModuleFactoryCreateData,
   ModuleGraph, ModuleGraphConnection, ModuleIdentifier, NormalModuleCreateData,
-  NormalModuleFactoryModule, Plugin, PrefetchExportsInfoMode, RayonConsumer,
-  ResolvedExportInfoTarget, SideEffectsBailoutItemWithSpan, SideEffectsDoOptimize,
-  SideEffectsDoOptimizeMoveTarget,
+  NormalModuleFactoryModule, Plugin, PrefetchExportsInfoMode, ResolvedExportInfoTarget,
+  SideEffectsBailoutItemWithSpan, SideEffectsDoOptimize, SideEffectsDoOptimizeMoveTarget,
   incremental::{self, IncrementalPasses, Mutation},
 };
 use rspack_error::Result;
@@ -741,7 +740,7 @@ async fn optimize_dependencies(&self, compilation: &mut Compilation) -> Result<O
   logger.time_end(inner_start);
 
   let inner_start = logger.time("find optimizable connections");
-  modules
+  let dep_optimize_info = modules
     .par_iter()
     .filter(|module| side_effects_state_map[module] == ConnectionState::Active(false))
     .flat_map(|module| {
@@ -755,13 +754,14 @@ async fn optimize_dependencies(&self, compilation: &mut Compilation) -> Result<O
         can_optimize_connection(connection, &side_effects_state_map, &module_graph),
       )
     })
-    .consume(|(dep_id, can_optimize)| {
-      if let Some(do_optimize) = can_optimize {
-        side_effects_optimize_artifact.insert(dep_id, do_optimize);
-      } else {
-        side_effects_optimize_artifact.remove(&dep_id);
-      }
-    });
+    .collect::<Vec<_>>();
+  for (dep_id, can_optimize) in dep_optimize_info {
+    if let Some(do_optimize) = can_optimize {
+      side_effects_optimize_artifact.insert(dep_id, do_optimize);
+    } else {
+      side_effects_optimize_artifact.remove(&dep_id);
+    }
+  }
   logger.time_end(inner_start);
 
   let mut do_optimizes = side_effects_optimize_artifact.clone();

tests/e2e/cases/incremental/remove-optimized-module/index.test.ts

@@ -9,9 +9,6 @@ test("remove optimized module should not panic", async ({
 	fileAction.deleteFile("comp/Button.js");
 
 	const overlay = page.frameLocator("#webpack-dev-server-client-overlay");
-	await expect(
-		overlay.getByText("ESModulesLinkingWarning: export 'Button'")
-	).toBeVisible();
 	await expect(
 		overlay.getByText("Module not found: Can't resolve './Button'")
 	).toBeVisible();