Upload thumbnails for session recordings as they're generated #60313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanclark
added
no-changelog
github-actions
bot
added
audit-log
ryanclark
force-pushed
the
ryan/write-thumbnails-on-creation
branch
from
1bb991c to
d6a9e5f
Compare
strideynet
approved these changes
Oct 17, 2025
lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go
Outdated
Show resolved
Hide resolved
rana
reviewed
Oct 20, 2025
lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go
Outdated
Show resolved
Hide resolved
lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go
Outdated
Show resolved
Hide resolved
lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go
Outdated
Show resolved
Hide resolved
lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata_test.go
Show resolved
Hide resolved
ryanclark
force-pushed
the
ryan/write-thumbnails-on-creation
branch
from
16a7122 to
2b9b927
Compare
tigrato
approved these changes
Oct 22, 2025
smallinsky
approved these changes
Oct 22, 2025
rana
approved these changes
Oct 22, 2025
ryanclark
force-pushed
the
ryan/write-thumbnails-on-creation
branch
from
9753342 to
d736fcd
Compare
Contributor
|
@ryanclark See the table below for backport results.
|
smallinsky
pushed a commit
that referenced
this pull request
Oct 23, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the session recording processor to upload thumbnails as soon as they're generated, instead of keeping them all in memory and uploading at the end.
To do this, a pipe is created and passed through to
UploadMetadata, and the thumbnails are marshalled into the pipe writer on creation. To accommodate this, the session duration needed to be known before processing. The start/end event times are tracked during the session upload (using the last print/resize event time if there is no end event), and passed through at the end when it is processedI had to modify the
GetMetadatato handle thumbnails/metadata being stored in the metadata protobuf file in any orderThis + the previous PR takes the total memory allocation of
ProcessSessionRecordingfrom ~257mb to ~283kb, a 930x reduction#60266 took it from 257mb (325mb total minus 68mb for upload) to ~14mb (62mb minus 48mb for upload)
This takes it from 14mb to 283kb (24.86mb usage minus 24.58mb for upload)