Skip to content

Commit 9753342

Browse files
committed
Add comment about only warning if thumbnail couldn't be marshalled
1 parent 2b9b927 commit 9753342

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ func (s *RecordingMetadataService) ProcessSessionRecording(ctx context.Context,
166166
}
167167

168168
if _, err := protodelim.MarshalTo(w, thumbnail); err != nil {
169+
// log the error but continue processing other thumbnails and the session metadata (metadata is more important)
169170
s.logger.WarnContext(ctx, "Failed to marshal thumbnail entry",
170171
"session_id", sessionID, "error", err)
171172
}

0 commit comments

Comments
 (0)