Use the thumbnail that is as close to the thumbnail time

Author: ryanclark

lib/auth/recordingmetadata/recordingmetadatav1/recordingmetadata.go

@@ -23,6 +23,7 @@ import (
 	"context"
 	"io"
 	"log/slog"
+	"math"
 	"math/rand/v2"
 	"sync"
 	"time"
@@ -169,9 +170,17 @@ func (s *RecordingMetadataService) ProcessSessionRecording(ctx context.Context,
 				"session_id", sessionID, "error", err)
 		}
 
-		if startOffset < thumbnailTime {
-			// keep updating the recording thumbnail until we reach the ideal thumbnail time (in case there are
-			// periods of inactivity and no thumbnails are captured for a while)
+		if recordingThumbnail == nil {
+			recordingThumbnail = thumbnail
+
+			return
+		}
+
+		previousDiff := math.Abs(float64(thumbnailTime - recordingThumbnail.StartOffset.AsDuration()))
+		diff := math.Abs(float64(thumbnailTime - startOffset))
+
+		if diff < previousDiff {
+			// this thumbnail is closer to the ideal thumbnail time, use it instead
 			recordingThumbnail = thumbnail
 		}
 	}