Add a semaphore to recording processing #60270
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanclark
added
no-changelog
tigrato
approved these changes
Oct 15, 2025
| maxThumbnails = 1000 | ||
|
|
||
| // concurrencyLimit limits the number of concurrent processing operations. | ||
| concurrencyLimit = 5 |
There was a problem hiding this comment.
maybe 5 is a bit low, isn't it?
There was a problem hiding this comment.
It definitely feels like we'd either want a metric (or a log message when it's blocked on acquiring a semaphore) to at least figure out if this is acting as a choke point in production. Do we have a rough idea of how long processing a session takes vs the length of the session?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the concurrency of session processing to 5 at a time