-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Minor: split datafusion-cli testing into its own CI job #15075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
234c8ec
to
327c1e4
Compare
run: git diff --exit-code | ||
|
||
# datafusion-cli tests | ||
linux-test-datafusion-cli: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the point is to split the run into its own job into its own test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was it intentional to keep cli tests for mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not -- I will remove it. Good point
Update: I actually think it is good to have the mac tests still run (even if not integration tests) to provide basic coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking especially newlne / formatting nonsense that is subtly different on mac
- name: Run tests (excluding doctests and datafusion-cli) | ||
env: | ||
RUST_BACKTRACE: 1 | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datafusion-cli is excluded here now
I also expanded out this list of tests to make it easier to read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks @alamb its about time, for each platform we recompile and run tests for datafusion cli, although just having a linux is enough
THanks -- filed a ticket to track this |
Which issue does this PR close?
Draft as it build on #13672
insta
/ snapshot testing to CLI & set up AWS mock #13672Rationale for this change
Let's keep the CI runs quick and efficient
While datafusion-cli is part of the main workspace now (and will get tested with
cargo test
I think it should be its own CI job because:insta
/ snapshot testing to CLI & set up AWS mock #13672 it also uses a docker container and some environment variables and I would like to keep the base CI test as simple as possibleWhat changes are included in this PR?
Move datafuson-cli test run to its own separate CI job
Are these changes tested?
Yes, see CI jobs below
Timing summary
Compared to this recent main CI runs (click links)
Are there any user-facing changes?