Skip to content

Minor: split datafusion-cli testing into its own CI job #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Minor: split datafusion-cli testing into its own CI job #15075

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
327c1e4
Minor: split datafusion-cli testing into its own CI job
alamb Mar 7, 2025
e8352a5
fix
alamb Mar 11, 2025
e3fcdf6
Merge remote-tracking branch 'apache/main' into alamb/separate_cli_ci
alamb Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ jobs:
- name: Check datafusion-functions (string_expressions)
run: cargo check --profile ci --all-targets --no-default-features --features=string_expressions -p datafusion-functions

# Run tests
# Library and integration tests
linux-test:
name: cargo test (amd64)
needs: linux-build-lib
Expand All @@ -180,6 +180,36 @@ jobs:
run: rustup toolchain install stable
- name: Install Protobuf Compiler
run: sudo apt-get install -y protobuf-compiler
- name: Run tests (excluding doctests and datafusion-cli)
env:
RUST_BACKTRACE: 1
run: |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datafusion-cli is excluded here now

I also expanded out this list of tests to make it easier to read

cargo test \
--profile ci \
--exclude datafusion-examples \
--exclude ffi_example_table_provider \
--exclude datafusion-benchmarks \
--exclude datafusion-cli \
--workspace \
--lib \
--tests \
--bins \
--features serde,avro,json,backtrace,integration-tests
- name: Verify Working Directory Clean
run: git diff --exit-code

# datafusion-cli tests
linux-test-datafusion-cli:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the point is to split the run into its own job into its own test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it intentional to keep cli tests for mac?

Copy link
Contributor Author

@alamb alamb Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not -- I will remove it. Good point

Update: I actually think it is good to have the mac tests still run (even if not integration tests) to provide basic coverage

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking especially newlne / formatting nonsense that is subtly different on mac

name: cargo test datafusion-cli (amd64)
needs: linux-build-lib
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
fetch-depth: 1
- name: Setup Rust toolchain
run: rustup toolchain install stable
- name: Setup Minio - S3-compatible storage
run: |
docker run -d --name minio-container \
Expand All @@ -200,13 +230,14 @@ jobs:
AWS_SECRET_ACCESS_KEY: TEST-DataFusionPassword
TEST_STORAGE_INTEGRATION: 1
AWS_ALLOW_HTTP: true
run: cargo test --profile ci --exclude datafusion-examples --exclude ffi_example_table_provider --exclude datafusion-benchmarks --workspace --lib --tests --bins --features avro,json,backtrace,integration-tests
run: cargo test --profile ci -p datafusion-cli --lib --tests --bins
- name: Verify Working Directory Clean
run: git diff --exit-code
- name: Minio Output
if: ${{ !cancelled() }}
run: docker logs minio-container


linux-test-example:
name: cargo examples (amd64)
needs: linux-build-lib
Expand Down