Skip to content

Consider only runnning datafusion-cli tests for linux (not mac) #15226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alamb opened this issue Mar 14, 2025 · 3 comments · Fixed by #15240
Closed

Consider only runnning datafusion-cli tests for linux (not mac) #15226

alamb opened this issue Mar 14, 2025 · 3 comments · Fixed by #15240
Assignees
@zhuqi-lucas

Comments

@alamb
Copy link
Contributor

alamb commented Mar 14, 2025 

          lgtm thanks @alamb its about time, for each platform we recompile and run tests for datafusion cli, although just having a linux is enough

Originally posted by @comphead in #15075 (review)
@alamb alamb mentioned this issue Mar 14, 2025
Merged
@zhuqi-lucas
Copy link
Contributor

take

@zhuqi-lucas zhuqi-lucas mentioned this issue Mar 15, 2025
Merged
@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Mar 15, 2025 •
edited
Loading

One more question, do we want to exclude more testing cases for mac, i see the linux case exclude the following:

--exclude datafusion-examples \
--exclude ffi_example_table_provider \
--exclude datafusion-benchmarks \
--exclude datafusion-cli \

@alamb
Copy link
Contributor Author

alamb commented Mar 15, 2025

wow a few hours from file to finish 🚀 thanks @xudong963 and @zhuqi-lucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhuqi-lucas zhuqi-lucas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor: exclude datafusion-cli testing for mac zhuqi-lucas/arrow-datafusion
2 participants
@alamb @zhuqi-lucas