Use glib's native asyncio integration when available #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
- Coverage 81.44% 79.46% -1.98%
==========================================
Files 22 23 +1
Lines 2387 2518 +131
==========================================
+ Hits 1944 2001 +57
- Misses 443 517 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 27, 2025
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025060102-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:11 performance degradations
Remaining performance tests:45 tests
|
This was referenced May 27, 2025
Merged
Member
Author
|
This doesn't work very well: |
This was referenced May 30, 2025
marmarta
approved these changes
Jun 1, 2025
Glib >= 3.50 has native asyncio integration. When available, use it instead of gbulb. This requires few minor changes: - asyncio.run() doesn't work there (asyncio.set_event_loop() cannot be called on the main thread with glib...) - gbulb needs explicit loop.run_forever()/loop.run_until_complete() to start the loop, the Glib version does it implicitly in app.run() QubesOS/qubes-issues#9809
The loop is already running at this point. This apparently didn't exploded with gbulb, but glib's asyncio loop raises an exception in this case. QubesOS/qubes-issues#9807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glib >= 3.50 has native asyncio integration. When available, use it
instead of gbulb.
This requires few minor changes:
called on the main thread with glib...)
QubesOS/qubes-issues#9809