-
-
Notifications
You must be signed in to change notification settings - Fork 6
archlinux: initial packaging #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
archlinux/PKGBUILD.in
Outdated
| prepare() { | ||
| cd "${_pkgnvr}" | ||
| export RUSTUP_TOOLCHAIN=stable | ||
| cargo fetch --target "$(rustc -vV | sed -n 's/host: //p')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing --locked (which means that a Cargo.lock needs to be added to the repo).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't Cargo.lock interfere with using system packages in every other distro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be stored with a different filename and renamed during the build.
|
BTW, since you are here, any idea for a better solution than disabling LTO? The error I got was: |
DemiMarie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-language LTO is possible, but my understanding is that it requires ensuring that rustc and clang are using the same version of LLVM. I wouldn’t bother with it in this case.
archlinux/PKGBUILD.in
Outdated
| prepare() { | ||
| cd "${_pkgnvr}" | ||
| export RUSTUP_TOOLCHAIN=stable | ||
| cargo fetch --target "$(rustc -vV | sed -n 's/host: //p')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be stored with a different filename and renamed during the build.
Based on https://wiki.archlinux.org/title/Rust_package_guidelines Add also Cargo.lock for Archlinux, but to not interfere with other distributions (which use distro packages), store it in archlinux/. Adjust .gitignore to not ignore it (cannot use '!' to exclude it, as it isn't supported by `tar --exclude-vcs-ignores`).
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025052803-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests47 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:12 performance degradations
Remaining performance tests:52 tests
|
Based on https://wiki.archlinux.org/title/Rust_package_guidelines