Wait for session only if necessary #571
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 71.10% 70.68% -0.42%
==========================================
Files 3 3
Lines 481 481
==========================================
- Hits 342 340 -2
- Misses 139 141 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025060710-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable testsPerformance TestsPerformance degradation:16 performance degradations
Remaining performance tests:56 tests
|
qubes-rpc/qubes.WaitForSession
Outdated
| done | ||
| set -eu | ||
|
|
||
| if qubesdb-read -q /qubes-gui-domain-xid >/dev/null; then |
There was a problem hiding this comment.
That isn't a good idea, it will also happen if GUI domain is started later. Adding -w option (to wait for the value) would help, but would also defeat the purpose of this condition. I don't think there is an easy way to distinguish the "no gui" from the "gui domain not started yet" case from within a VM. Maybe there should be a separate qubesdb entry for this info?
There was a problem hiding this comment.
Maybe there should be a separate qubesdb entry for this info?
Yeah, didn't think of the case of GUIVM not being started yet... a separate qubesdb entry makes sense as it could cover the guivm property and the gui feature.
There was a problem hiding this comment.
Using db entry /qubes-gui-enabled, now it depends on QubesOS/qubes-core-admin#660
The 'gui' feature is not passed via QubesDB to the qube, if it was, only one service would be necessary. For: QubesOS/qubes-issues#1512
ben-grande
force-pushed
the
preload-dispvm
branch
from
397ffc9 to
f9a21b6
Compare
3 participants
The 'gui' feature is not passed via QubesDB to the qube, if it was, only one service would be necessary.
For: QubesOS/qubes-issues#1512
This makes the handler for
domain-startsimpler, besides not having to sleep if there is no GUI for a qube.