selinux: fix qrexec-agent restart #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When qrexec-agent restarts, it needs to remove the old socket file before creating the new one. Let the agent do that when SELinux is enabled. Fixes QubesOS/qubes-issues#9982
Remove the socket on stop/restart, do not leave stale socket there. This makes qrexec-client-vm fail more clearly if the agent is not running. The agent still needs to remove it on startup too, to handle restart after a crash too, but lets make it a fallback option, not the only option. Related to QubesOS/qubes-issues#9982
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 78.87% 78.80% -0.08%
==========================================
Files 55 55
Lines 10519 10519
==========================================
- Hits 8297 8289 -8
- Misses 2222 2230 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 1, 2025
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025060120-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:17 performance degradations
Remaining performance tests:39 tests
|
This was referenced Jun 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When qrexec-agent restarts, it needs to remove the old socket file before
creating the new one. Let the agent do that when SELinux is enabled.
Fixes QubesOS/qubes-issues#9982
And also, remove the socket on shutdown too.