Fix test assertions to match actual renderer metadata value #11
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commits changed test assertions to expect "citeproc-py" as the renderer value, but the actual implementation returns "citeproc". This caused 4 tests to fail. Reverted the test assertions back to expecting "citeproc" which matches the actual behavior of render_bibliography_to_strings(). All rendering tests now pass. Co-authored-by: dosumis <[email protected]>
Copilot
AI
changed the title
[WIP] WIP Address feedback on dependencies and testing improvements
Fix test assertions to match actual renderer metadata value
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous commits incorrectly changed test assertions to expect
"citeproc-py"as the renderer value, butrender_bibliography_to_strings()returns"citeproc". This caused 4 tests to fail.Changes
meta["renderer"]assertions from"citeproc-py"to"citeproc"in:test_render_bibliography_vancouver_styletest_render_bibliography_chicago_styletest_render_bibliography_empty_citationstest_render_bibliography_with_localeThe implementation at
api.py:627explicitly returns{"renderer": "citeproc", ...}on success, so tests must match this behavior.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.