Added missing dependency and improved testing #9
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the missing citeproc-py and citeproc-py-styles dependencies and introduces comprehensive test coverage for bibliography rendering functionality with multiple citation styles.
- Added
citeproc-py>=0.9.0andciteproc-py-styles>=0.1.5to project dependencies - Added 6 new test cases covering vancouver, APA, and chicago styles, multiple citations, empty citations, and locale handling
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| pyproject.toml | Added citeproc-py and citeproc-py-styles as project dependencies with minimum version requirements |
| uv.lock | Updated lock file with new dependency entries including citeproc-py v0.9.0 and citeproc-py-styles v0.1.5 |
| tests/unit/test_rendering.py | Added 6 new test cases for bibliography rendering with various styles and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| rendered, meta = render_bibliography_to_strings(result, style="vancouver") | ||
|
|
||
| assert meta["renderer"] == "citeproc" |
There was a problem hiding this comment.
The assertion checks for meta["renderer"] == "citeproc", but the actual value returned by render_bibliography_to_strings is "citeproc-py". This test will fail. The assertion should be changed to check for "citeproc-py" instead of "citeproc".
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
|
||
| rendered, meta = render_bibliography_to_strings(result, style="apa") | ||
|
|
||
| assert meta["renderer"] == "citeproc", ( |
There was a problem hiding this comment.
The assertion checks for meta["renderer"] == "citeproc", but the actual value returned by render_bibliography_to_strings is "citeproc-py". This test will fail. The assertion should be changed to check for "citeproc-py" instead of "citeproc".
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot can you please revert cyteproc --> cyteproc-py changes. Causing fails |
Co-authored-by: dosumis <[email protected]>
…gain Revert citeproc renderer name changes causing test failures
fixing failing tests
add