Skip to content

Fix test assertions to match actual renderer metadata value #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix test assertions to match actual renderer metadata value #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2cc8b
Initial plan
Copilot Dec 14, 2025
26d6f19
Revert incorrect test assertions for renderer metadata
Copilot Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/unit/test_rendering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def test_render_bibliography_vancouver_style():
rendered, meta = render_bibliography_to_strings(result, style="vancouver")

# Should use citeproc renderer with citeproc-py-styles installed
assert meta["renderer"] == "citeproc-py", (
"Expected citeproc-py renderer but got fallback. "
assert meta["renderer"] == "citeproc", (
"Expected citeproc renderer but got fallback. "
"Ensure citeproc-py-styles is installed: pip install citeproc-py-styles"
)
assert meta["style"] == "vancouver"
Expand Down Expand Up @@ -134,7 +134,7 @@ def test_render_bibliography_chicago_style():

rendered, meta = render_bibliography_to_strings(result, style="chicago")

assert meta["renderer"] == "citeproc-py"
assert meta["renderer"] == "citeproc"
assert meta["style"] == "chicago"
assert len(rendered) == 1
assert rendered[0] # Non-empty
Expand Down Expand Up @@ -198,7 +198,7 @@ def test_render_bibliography_empty_citations():
rendered, meta = render_bibliography_to_strings(result, style="vancouver")

# Even with no citations, should use citeproc if available
assert meta["renderer"] in ["citeproc-py", "fallback"]
assert meta["renderer"] in ["citeproc", "fallback"]
assert meta["style"] == "vancouver"
assert len(rendered) == 0, "Should have no bibliography entries"

Expand All @@ -224,6 +224,6 @@ def test_render_bibliography_with_locale():
result, style="vancouver", locale="en-GB"
)

assert meta["renderer"] == "citeproc-py"
assert meta["renderer"] == "citeproc"
assert meta["locale"] == "en-GB"
assert len(rendered) == 1