-
Notifications
You must be signed in to change notification settings - Fork 71
Update protobuf-java to 4.33.1 #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant version upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Scala Steward, updates protobuf-java to version 4.33.1. This is a major version upgrade that introduces a critical compatibility issue. The project uses grpc-java version 1.76.0, which is not compatible with protobuf-java 4.x. This will likely lead to runtime errors. I've added a critical review comment suggesting to revert this change to maintain compatibility and prevent runtime failures.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.33.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This major version upgrade of protobuf-java to 4.33.1 is incompatible with the grpc-java version (1.76.0) used in this project.
The io.grpc:grpc-protobuf:1.76.0 dependency is built against com.google.protobuf:protobuf-java:3.25.3. Forcing a much newer protobuf-java with major version differences will almost certainly cause runtime failures (like NoSuchMethodError) due to breaking API changes between protobuf-java 3.x and 4.x.
To avoid breaking the benchmark module, this change should be reverted. If you need to update protobuf-java, please ensure the new version is compatible with grpc-java:1.76.0.
"com.google.protobuf" % "protobuf-java" % "3.25.8",
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.33.1⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: