Skip to content

Update protobuf-java to 4.33.1 #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update protobuf-java to 4.33.1 #4094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ lazy val benchmark =
// "com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion
// For grpc-java
"io.grpc" % "grpc-protobuf" % GRPC_VERSION,
"com.google.protobuf" % "protobuf-java" % "3.25.8",
"com.google.protobuf" % "protobuf-java" % "4.33.1",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This major version upgrade of protobuf-java to 4.33.1 is incompatible with the grpc-java version (1.76.0) used in this project.

The io.grpc:grpc-protobuf:1.76.0 dependency is built against com.google.protobuf:protobuf-java:3.25.3. Forcing a much newer protobuf-java with major version differences will almost certainly cause runtime failures (like NoSuchMethodError) due to breaking API changes between protobuf-java 3.x and 4.x.

To avoid breaking the benchmark module, this change should be reverted. If you need to update protobuf-java, please ensure the new version is compatible with grpc-java:1.76.0.

        "com.google.protobuf" % "protobuf-java" % "3.25.8",

("com.chatwork" %% "scala-ulid" % "1.0.24").cross(CrossVersion.for3Use2_13)
)
// Compile / PB.targets := Seq(
Expand Down
Loading