-
Notifications
You must be signed in to change notification settings - Fork 71
Update protobuf-java to 4.33.0 #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance task by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Scala Steward updates protobuf-java to version 4.33.0. This is a major version update that introduces critical compatibility issues. The new version is incompatible with grpc-java, which is used in the project, and the version number itself seems to be incorrect for the protobuf-java artifact. I strongly recommend rejecting this update and closing the pull request to avoid breaking the build.
| // For grpc-java | ||
| "io.grpc" % "grpc-protobuf" % GRPC_VERSION, | ||
| "com.google.protobuf" % "protobuf-java" % "3.25.8", | ||
| "com.google.protobuf" % "protobuf-java" % "4.33.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to protobuf-java:4.33.0 should be rejected for the following critical reasons:
-
Compatibility with gRPC-Java: The project uses
grpc-javaversion1.76.0, which depends onprotobuf-java:3.25.3. The officialgrpc-javadocumentation states that it is only compatible withprotobuf-java3.x. This major version jump will break thebenchmarkmodule. -
Incorrect Version: The version
4.33.0does not appear to be a valid version for theprotobuf-javaartifact on Maven Central. The latest stable version in the 3.x series is3.25.3. It's likely that Scala Steward has incorrectly picked a version from a different artifact.
As per the PR description, please close this PR to skip this invalid update.
|
Superseded by #4094. |
About this PR
📦 Updates com.google.protobuf:protobuf-java from
3.25.8to4.33.0⚠Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: