[Misc] Check AI Runtime download env settings #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me |
Jeffwan
approved these changes
Sep 25, 2024
This was referenced Sep 26, 2024
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* fix: assert DOWNLOADER_MODEL_NAME setting during download from tos or s3 * test: add test case about model name not set * test: fix tos func name * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If the
DOWNLOADER_MODEL_NAMEis not set in TOS and s3 downloads, an AssertError will be thrown.Due to the fact that S3 and TOS support anonymous downloads, we cannot directly throw AttributeError if the credentials is missed (aibrix throw AttributeError if the credentials is missed #208). In this PR, we set the default value of ak sk for TOS to
''to ensure that the error'NoneType' object has no attribute 'strip'does not occur. (TOS SDK not support ak sk is None)Related Issues
Resolves: #212, #208
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.