Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOWNLOADER_MODEL_NAME blocks the runtime to download other models #212

Closed
Jeffwan opened this issue Sep 24, 2024 · 1 comment · Fixed by #221 or #250
Closed

DOWNLOADER_MODEL_NAME blocks the runtime to download other models #212

Jeffwan opened this issue Sep 24, 2024 · 1 comment · Fixed by #221 or #250
Assignees
Labels
area/runtime event/bugbash issues reported at bug bash kind/bug Something isn't working kind/enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 24, 2024

🐛 Describe the bug

The behavior is a little bit weird. When I tried to download the deepseek-ai/deepseek-coder-6.7b-instruct. everything works fine.

After that, I started to download another smaller model using the same model path (huggingface model in /tmp/aibrix/model_tos)

the screenshot is the 2nd time I download opt model, I notice I didn't change the environment, it's supposed to override it but not really.

# 1st model
python -m aibrix.downloader \
    --model-uri tos://aibrix-artifact-testing/models/deepseek-ai/deepseek-coder-6.7b-instruct/ \
    --local-dir /tmp/aibrix/models_tos/

# 2nd model
python3 -m aibrix.downloader     --model-uri facebook/opt-125m     --local-dir /tmp/aibrix/models_tos

We should definitely infer the model folder instead of pass it, or we can accept an argument for override.

image

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response

@Jeffwan Jeffwan added kind/bug Something isn't working kind/enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/runtime event/bugbash issues reported at bug bash labels Sep 24, 2024
@Jeffwan Jeffwan modified the milestones: v0.1.0-rc.3, v0.1.0-rc.2 Sep 25, 2024
@Jeffwan Jeffwan reopened this Sep 26, 2024
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 26, 2024

#221 is the enhancement on the error message. if we want to repeatedly download the model, DOWNLOADER_MODEL_NAME is definitely a blocker issue. For example, if we want to reuse the download tools to download lora model in runtime. we can easily override with arguments but hard to inject different envs everytime. I still suggest to infer the model name from the url list with argument override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime event/bugbash issues reported at bug bash kind/bug Something isn't working kind/enhancement New feature or request priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
2 participants