Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aibrix downloader failed to download models in S3 #213

Closed
Jeffwan opened this issue Sep 24, 2024 · 4 comments
Closed

aibrix downloader failed to download models in S3 #213

Jeffwan opened this issue Sep 24, 2024 · 4 comments
Assignees
@brosoul
Labels
area/runtime event/bugbash issues reported at bug bash kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v0.1.0-rc.3

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Sep 24, 2024

🐛 Describe the bug

image

I didn't take close look on this issue.

Steps to Reproduce

No response

Expected behavior

No response

Environment

No response
@Jeffwan Jeffwan added kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/runtime event/bugbash issues reported at bug bash labels Sep 24, 2024
@Jeffwan Jeffwan changed the title aibrix download failed to download models in S3 aibrix downloader failed to download models in S3 Sep 25, 2024
@brosoul
Copy link
Collaborator

brosoul commented Sep 25, 2024

In the current implementation, when downloading a file from tos or s3, you need to display the settings DOWNLOADER_MODEL_NAME to specify the directory where the model is saved. @Jeffwan

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 25, 2024

@brosoul that's ok but we need to return the reasonable messages. This is similar to #208. It would be hard for users to debug without those knowledges

@Jeffwan Jeffwan added this to the v0.1.0-rc.3 milestone Sep 25, 2024
@brosoul
Copy link
Collaborator

brosoul commented Sep 26, 2024

I think this issue has already been resolved in #221 .

Did I misunderstand this issue? Can we discuss it offline.
@Jeffwan

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Sep 27, 2024 •
edited
Loading

After checking above messages and logs, I think #221 fully resolves this issue. We can close it. the enhancement of using DOWNLOADER_MODEL_NAME is tracked here. I moved to RC3.

@Jeffwan Jeffwan closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosoul brosoul

Labels
area/runtime event/bugbash issues reported at bug bash kind/bug Something isn't working priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v0.1.0-rc.3
Development

No branches or pull requests
2 participants
@Jeffwan @brosoul