perf: optimize cell_data serialization format #88401

lukesandberg · 2026-01-12T05:56:21Z

No description provided.

lukesandberg · 2026-01-12T05:56:42Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

vercel · 2026-01-12T06:03:15Z

turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs

+            let (encode_fn, _) = value_type.bincode.ok_or_else(|| {
+                bincode::error::EncodeError::OtherString(format!(
+                    "{} is not encodable",
+                    value_type.global_name


Non-deterministic FxHashMap iteration causes inconsistent binary serialization in encode_custom_fields

vercel · 2026-01-12T06:03:15Z

turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs

+        let transient_entries: Vec<_> = self
+            .cell_type_max_index()
+            .map(|map| {
+                map.iter()


Cell type max_index values are lost during serialization/deserialization when cells are removed, causing incorrect bounds validation on restored tasks

nextjs-bot · 2026-01-12T06:17:12Z

Stats from current PR

🟢 1 improvement

Metric	Canary	PR	Change	Trend
node_modules Size	457 MB	457 MB	🟢 164 kB (0%)	█████

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	455ms	455ms	✓	▁▁▁█▁
Cold (First Request)	1.175s	1.157s	✓	█▁█▂▇
Warm (Listen)	457ms	457ms	✓	▆▃▆▃▆
Warm (First Request)	345ms	344ms	✓	▁▁▆██

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	455ms	456ms	✓	█▁███
Cold (First Request)	1.813s	1.812s	✓	▅▄▄▄█
Warm (Listen)	456ms	457ms	✓	▅▁▅▅▅
Warm (First Request)	1.836s	1.812s	✓	▆▄▆▄█

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	4.064s	4.097s	✓	▂▄▁█▁
Cached Build	4.109s	4.037s	✓	▁▄▁█▁

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	13.907s	13.903s	✓	▃▁▂▂█
Cached Build	14.009s	13.952s	✓	▂▁▂▁█
node_modules Size	457 MB	457 MB	🟢 164 kB (0%)	█████

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -135 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	788 B	792 B	✓
Total	788 B	792 B	⚠️ +4 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	451 B	450 B	✓
Total	451 B	450 B	✅ -1 B

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
2086.HASH.js gzip	169 B	N/A	-
2161-HASH.js gzip	5.41 kB	N/A	-
2747-HASH.js gzip	4.48 kB	N/A	-
4322-HASH.js gzip	52.8 kB	N/A	-
ec793fe8-HASH.js gzip	62.3 kB	N/A	-
framework-HASH.js gzip	59.8 kB	59.8 kB	✓
main-app-HASH.js gzip	251 B	254 B	🔴 +3 B (+1%)
main-HASH.js gzip	38.6 kB	39 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
1596.HASH.js gzip	N/A	169 B	-
2658-HASH.js gzip	N/A	52.5 kB	-
6349-HASH.js gzip	N/A	4.46 kB	-
7019-HASH.js gzip	N/A	5.43 kB	-
b17a3386-HASH.js gzip	N/A	62.3 kB	-
Total	225 kB	225 kB	⚠️ +72 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	193 B	✓
_error-HASH.js gzip	182 B	182 B	✓
css-HASH.js gzip	336 B	335 B	✓
dynamic-HASH.js gzip	1.8 kB	1.8 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	352 B	349 B	✓
hooks-HASH.js gzip	385 B	384 B	✓
image-HASH.js gzip	580 B	580 B	✓
index-HASH.js gzip	259 B	258 B	✓
link-HASH.js gzip	2.5 kB	2.51 kB	✓
routerDirect..HASH.js gzip	319 B	317 B	✓
script-HASH.js gzip	385 B	387 B	✓
withRouter-HASH.js gzip	316 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.97 kB	7.96 kB	✅ -8 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	239 kB	239 kB	✓
Total	364 kB	364 kB	✅ -199 B

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	653 B	653 B	✓
middleware-r..fest.js gzip	155 B	156 B	✓
middleware.js gzip	33 kB	33.1 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	34.6 kB	34.7 kB	⚠️ +117 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	738 B	738 B	✓
Total	738 B	738 B	✓

Build Cache

	Canary	PR	Change
0.pack gzip	3.62 MB	3.61 MB	🟢 5.13 kB (0%)
index.pack gzip	98.8 kB	99.5 kB	✓
index.pack.old gzip	98.9 kB	99.1 kB	✓
Total	3.82 MB	3.81 MB	✅ -4.29 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	303 kB	303 kB	✓
app-page-exp..prod.js gzip	158 kB	157 kB	✓
app-page-tur...dev.js gzip	303 kB	302 kB	✓
app-page-tur..prod.js gzip	158 kB	157 kB	✓
app-page-tur...dev.js gzip	299 kB	299 kB	✓
app-page-tur..prod.js gzip	156 kB	155 kB	✓
app-page.run...dev.js gzip	300 kB	299 kB	✓
app-page.run..prod.js gzip	156 kB	155 kB	✓
app-route-ex...dev.js gzip	68.2 kB	68.2 kB	✓
app-route-ex..prod.js gzip	46.9 kB	46.9 kB	✓
app-route-tu...dev.js gzip	68.2 kB	68.2 kB	✓
app-route-tu..prod.js gzip	46.9 kB	46.9 kB	✓
app-route-tu...dev.js gzip	67.8 kB	67.8 kB	✓
app-route-tu..prod.js gzip	46.7 kB	46.7 kB	✓
app-route.ru...dev.js gzip	67.8 kB	67.8 kB	✓
app-route.ru..prod.js gzip	46.7 kB	46.7 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	41.1 kB	41.1 kB	✓
pages-api-tu..prod.js gzip	31.2 kB	31.2 kB	✓
pages-api.ru...dev.js gzip	41.1 kB	41.1 kB	✓
pages-api.ru..prod.js gzip	31.2 kB	31.2 kB	✓
pages-turbo....dev.js gzip	50.8 kB	50.8 kB	✓
pages-turbo...prod.js gzip	38.2 kB	38.2 kB	✓
pages.runtim...dev.js gzip	50.8 kB	50.8 kB	✓
pages.runtim..prod.js gzip	38.2 kB	38.2 kB	✓
server.runti..prod.js gzip	62 kB	62 kB	✓
Total	2.68 MB	2.67 MB	✅ -2.34 kB

📝 Changed Files (10 files)

Files with changes:

app-page-exp..ntime.dev.js
app-page-exp..time.prod.js
app-page-tur..ntime.dev.js
app-page-tur..time.prod.js
app-page-tur..ntime.dev.js
app-page-tur..time.prod.js
app-page.runtime.dev.js
app-page.runtime.prod.js
pages-api-tu..time.prod.js
pages-turbo...time.prod.js

View diffs

app-page-exp..ntime.dev.js

failed to diff

app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js

failed to diff

app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js

failed to diff

app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js

failed to diff

app-page.runtime.prod.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

nextjs-bot · 2026-01-12T06:18:46Z

Allow CI Workflow Run

approve CI run for commit: 8f4edd3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

nextjs-bot · 2026-01-12T06:18:46Z

Allow CI Workflow Run

approve CI run for commit: 8f4edd3

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

codspeed-hq · 2026-01-12T06:19:19Z

Merging this PR will improve performance by 5.42%

⚡ 7 improved benchmarks
✅ 2 untouched benchmarks
⏩ 11 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`build[shiki]`	5.5 s	5.3 s	+3.19%
⚡	Simulation	`build[date-fns-all]`	2.3 s	2.2 s	+3.96%
⚡	Simulation	`build[lucide-react-all]`	8.3 s	7.9 s	+5.42%
⚡	Simulation	`build[framer-motion-all]`	3 s	2.9 s	+4.61%
⚡	Simulation	`build[joy]`	2.1 s	2 s	+3.58%
⚡	Simulation	`build[mui]`	3.1 s	3 s	+4.58%
⚡	Simulation	`build[framer-motion-single]`	2.2 s	2.2 s	+3.37%

_{Comparing 01-10-optimize-cell-data-serialization (8f4edd3) with canary (38ac035)²}

11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on 01-09-migrate-to-typed-accessors (a31d0fb) during the generation of this report, so canary (38ac035) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This was referenced Jan 12, 2026

refactor: migrate to typed accessors and remove CachedDataItem adapter #88397

Draft

feat: add TaskStorage derive macro and schema infrastructure #88338

Open

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 12, 2026

lukesandberg mentioned this pull request Jan 12, 2026

docs: add rebuild guidance and ICE troubleshooting to AGENTS.md #88337

Merged

vercel bot reviewed Jan 12, 2026

View reviewed changes

lukesandberg marked this pull request as draft January 12, 2026 07:32

lukesandberg force-pushed the 01-09-migrate-to-typed-accessors branch from a31d0fb to de4b361 Compare January 12, 2026 07:43

lukesandberg force-pushed the 01-10-optimize-cell-data-serialization branch from 8f4edd3 to 422aca4 Compare January 12, 2026 07:43

lukesandberg marked this pull request as ready for review January 12, 2026 07:50

lukesandberg marked this pull request as draft January 12, 2026 16:25

lukesandberg force-pushed the 01-09-migrate-to-typed-accessors branch from de4b361 to 5cf311e Compare January 12, 2026 16:59

lukesandberg force-pushed the 01-10-optimize-cell-data-serialization branch from 422aca4 to f74d192 Compare January 12, 2026 16:59

lukesandberg force-pushed the 01-09-migrate-to-typed-accessors branch from 5cf311e to cd8f1c3 Compare January 12, 2026 17:49

lukesandberg force-pushed the 01-10-optimize-cell-data-serialization branch from f74d192 to 1bb53cb Compare January 12, 2026 17:50

lukesandberg force-pushed the 01-09-migrate-to-typed-accessors branch from cd8f1c3 to 4b82cc7 Compare January 12, 2026 18:16

lukesandberg force-pushed the 01-10-optimize-cell-data-serialization branch from 1bb53cb to b50a4fc Compare January 12, 2026 18:17

perf: optimize cell_data serialization format

70993e5

lukesandberg force-pushed the 01-09-migrate-to-typed-accessors branch from 4b82cc7 to bbbc722 Compare January 12, 2026 22:48

lukesandberg force-pushed the 01-10-optimize-cell-data-serialization branch from b50a4fc to 70993e5 Compare January 12, 2026 22:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf: optimize cell_data serialization format #88401

perf: optimize cell_data serialization format #88401

lukesandberg commented Jan 12, 2026

Uh oh!

lukesandberg commented Jan 12, 2026 •

edited

Loading

Uh oh!

vercel bot Jan 12, 2026 •

edited

Loading

Uh oh!

vercel bot Jan 12, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Jan 12, 2026

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

nextjs-bot commented Jan 12, 2026

Uh oh!

nextjs-bot commented Jan 12, 2026

Uh oh!

codspeed-hq bot commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

perf: optimize cell_data serialization format #88401

Are you sure you want to change the base?

perf: optimize cell_data serialization format #88401

Conversation

lukesandberg commented Jan 12, 2026

Uh oh!

lukesandberg commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nextjs-bot commented Jan 12, 2026

Stats from current PR

🟢 1 improvement

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

nextjs-bot commented Jan 12, 2026

Uh oh!

nextjs-bot commented Jan 12, 2026

Uh oh!

codspeed-hq bot commented Jan 12, 2026

Merging this PR will improve performance by 5.42%

Performance Changes

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lukesandberg commented Jan 12, 2026 •

edited

Loading

vercel bot Jan 12, 2026 •

edited

Loading

vercel bot Jan 12, 2026 •

edited

Loading