fix(turbo-tasks-backend): use correct TaskDataCategory for is_immutable check #88331
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
Contributor
Author
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **430 kB** → **430 kB** ✅ -26 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
lukesandberg
commented
Jan 9, 2026
Collaborator
Tests Passed |
Merging this PR will not alter performance
Comparing 
Footnotes
|
…le check The `is_immutable()` function was using `self.task.contains_key()` directly instead of going through the `has_key()` method which enforces `check_access()`. This means the Immutable flag (stored in Meta category) could be read without ensuring the Meta category data was actually loaded. Additionally, a call site checking immutability during task completion was using `TaskDataCategory::Data` when it should use `TaskDataCategory::Meta` since `Immutable` is stored in the Meta category. Changes: - Move `is_immutable()` to be a default implementation on the TaskGuard trait using `has_key()` which calls `check_access()` - Fix task completion immutability check to use `TaskDataCategory::Meta` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
lukesandberg
force-pushed
the
fix-is-immutable-category
branch
from
fa8d88f to
3ac147f
Compare
This was referenced Jan 10, 2026
bgw
approved these changes
Jan 12, 2026
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix task immutability check by using correct TaskDataCategory
What?
This PR fixes a bug in the task immutability check by ensuring we use
TaskDataCategory::Metainstead ofTaskDataCategory::Datawhen checking if dependent tasks are immutable.Why?
The immutable flag is stored in the Meta category, but we were incorrectly checking the Data category. This could prevent us from reading the immutable flag if Meta hadn't been restored for the task.
How?
TaskDataCategory::DatatoTaskDataCategory::Metawhen reading tasks where we neededimmutabilityis_immutable()implementation fromTaskGuardImplto theTaskGuardtrait with a default implementation that useshas_key(&CachedDataItemKey::Immutable {})which enforces correct access modes