perf(turbo-tasks-backend): use DefaultStorage for AggregationNumber to save memory #88336
+138
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
Contributor
Author
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This was referenced Jan 9, 2026
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **431 kB** → **431 kB** ✅ -10 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
sokra
approved these changes
Jan 9, 2026
lukesandberg
force-pushed
the
01-09-niche-optimization-aggregation-number
branch
from
fc6c9dd to
cf617ff
Compare
lukesandberg
force-pushed
the
fix-is-immutable-category
branch
from
fa8d88f to
3ac147f
Compare
| type V = V; | ||
| type Iterator<'l> | ||
| = std::option::IntoIter<(&'l (), &'l V)> | ||
| where |
Contributor
There was a problem hiding this comment.
DefaultStorage treats values equal to V::default() as "not present", causing AggregationNumber to be missing from snapshots and iteration even though it's semantically always present
This was referenced Jan 12, 2026
lukesandberg
changed the base branch from
fix-is-immutable-category
to
graphite-base/88336
…o save memory Replace `OptionStorage<AggregationNumber>` with `DefaultStorage<AggregationNumber>` in InnerStorage and InnerStorageSnapshot. DefaultStorage stores the value directly without an Option wrapper, using `Default::default()` to represent "empty". This saves 4 bytes per value: - DefaultStorage<AggregationNumber>: 12 bytes (same as AggregationNumber itself) - OptionStorage<AggregationNumber>: 16 bytes (12 + 4 for Option tag) This is semantically correct because AggregationNumber's default value (base=0, distance=0, effective=0) represents a non-aggregating leaf node, which is equivalent to "not set" in the aggregation system. The overall InnerStorage size remains 128 bytes due to alignment, but this matches common allocator bucket sizes meaning no wasted space from internal alignment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
lukesandberg
force-pushed
the
graphite-base/88336
branch
from
3ac147f to
76a15d8
Compare
lukesandberg
force-pushed
the
01-09-niche-optimization-aggregation-number
branch
from
cf617ff to
3f6698f
Compare
lukesandberg
force-pushed
the
01-09-niche-optimization-aggregation-number
branch
from
3f6698f to
0e3181f
Compare
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the size of the
aggregation_numberfield from 16 to 12 bytes which allows the fullInnerStoragestruct to do from 136 bytes to 128 bytes (thanks alignment!)Due to allocator behavior this is probably saving more like 32 bytes per InnerStorage allocation, see mimalloc size classes