chore(components): review and update prop validation across component library #4891
Conversation
🦋 Changeset detectedLatest commit: 3f61906 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
myrta2302
changed the title
|
Related Previews |
packages/components/src/components/post-breadcrumb/post-breadcrumb.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-card-control/post-card-control.tsx
Outdated
Show resolved
Hide resolved
|
| item.setAttribute('heading-level', String(newValue)); | ||
| }); | ||
| validateHeadingLevel() { | ||
| if (!checkNonEmpty(this, 'headingLevel')) { |
There was a problem hiding this comment.
There is a convention for functions that return a boolean: https://dev.to/michi/tips-on-naming-boolean-variables-cleaner-code-35ig Can you try and apply it here?
Otherwise would you be able to know if the property is required or not by inspecting the this? If so the check empty/non empty could be done automatically in the checkers and not manually in the components.
| this, | ||
| 'headingLevel', | ||
| HEADING_LEVELS, | ||
| 'The `heading-level` property of the `post-accordion` must be a number between 1 and 6.', |
There was a problem hiding this comment.
Is this custom message necessary? The goal of this PR would be to remove them.
There was a problem hiding this comment.
This file should probably not be deleted.
There was a problem hiding this comment.
Is that change really part of your PR?
PR Changes