Skip to content

chore(components): review prop validation (#2) - update validation functions and checkers #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

chore(components): review prop validation (#2) - update validation functions and checkers #5471

wants to merge 33 commits into from

Conversation

myrta2302
Copy link
Contributor

📄 Description

This PR updates the property checker functions along with the relevant watcher functions.

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • ✔️ New and existing unit tests pass locally with my changes

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 12, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fb401e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/internet-header Patch
@swisspost/design-system-styles-primeng-workspace Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myrta2302 myrta2302 changed the title chore(components) update validation functions and checkers chore(components): update validation functions and checkers May 12, 2025
@myrta2302 myrta2302 linked an issue May 12, 2025 that may be closed by this pull request
Review prop validation across component library #4651
Open
1 task
@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 12, 2025 •
edited
Loading

Related Previews

@myrta2302 myrta2302 changed the title chore(components): update validation functions and checkers chore(components): review prop validation (#2) - update validation functions and checkers May 12, 2025
myrta2302 and others added 10 commits May 12, 2025 13:18
@myrta2302
Merge branch 'main' into chore(components)-review-prop-initialization
127d5e6
@myrta2302
revert checkoneof
72244f5
@myrta2302
Merge branch 'chore(components)-review-prop-initialization' of https:…
72f298b 
…//github.com/swisspost/design-system into chore(components)-review-prop-initialization
@myrta2302
Merge branch 'main' into chore(components)-update-validation-function…
f1b7a1d 
…s-and-checkers
@myrta2302
fix e2e error
8fda6ca
@myrta2302
Merge branch 'main' into chore(components)-update-validation-function…
f7dc1f3 
…s-and-checkers
@myrta2302
Merge branch 'chore(components)-review-prop-initialization' into chor…
01db951 
…e(components)-update-validation-functions-and-checkers
@myrta2302
Merge branch 'chore(components)-update-validation-functions-and-check…
7d782fe 
…ers' of https://github.com/swisspost/design-system into chore(components)-update-validation-functions-and-checkers
@myrta2302
fix e2e error
f747969
@myrta2302
fix error
478e69a
@myrta2302 myrta2302 marked this pull request as ready for review May 13, 2025 14:10
@myrta2302 myrta2302 requested a review from a team as a code owner May 13, 2025 14:11
@myrta2302 myrta2302 requested a review from alizedebray May 13, 2025 14:11
@myrta2302 myrta2302 marked this pull request as draft May 16, 2025 12:34
@myrta2302
Copy link
Contributor Author

myrta2302 commented May 16, 2025 •
edited
Loading

Regading the second option, the required or optional metadata of the props are not available in this instance.
Will implement the naming convention for the validation functions in a following branch.

RESOLVED

@myrta2302
Copy link
Contributor Author

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@myrta2302 myrta2302 marked this pull request as ready for review May 19, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray Awaiting requested review from alizedebray alizedebray is a code owner automatically assigned from swisspost/design-system-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review prop validation across component library
2 participants
@myrta2302 @swisspost-bot