-
Notifications
You must be signed in to change notification settings - Fork 18
chore(components): review and update prop validation across component library #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
myrta2302
wants to merge
33
commits into
main
Choose a base branch
from
4651-review-prop-validation-across-component-library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6ff7c58
chore(components): review prop validation
myrta2302 4603baf
chore(components): prop validation update and 'warning' option
myrta2302 d4fe216
clean up
myrta2302 b141fba
test error
myrta2302 d079234
add changeset
myrta2302 0ca253d
Merge branch 'main' into 4651-review-prop-validation-across-component…
myrta2302 c49834e
minor updates
myrta2302 7e32b28
decision update
myrta2302 9332122
minor
myrta2302 2b2c5af
Merge branch 'main' into 4651-review-prop-validation-across-component…
myrta2302 9375967
remove warnings
myrta2302 e02c81d
adjust components
myrta2302 988bb34
prop and validation updates
myrta2302 87f9530
prop validation update
myrta2302 44193a7
for merge
myrta2302 90722e3
Merge branch 'main' into 4651-review-prop-validation-across-component…
myrta2302 3139ce7
update card control
myrta2302 68387c9
update card control
myrta2302 62fdab2
update rating and popover missing prop
myrta2302 3ae156e
update checkType for numbers
myrta2302 398bd6d
update post tag
myrta2302 138115e
minor
myrta2302 cd97429
tag colors update
myrta2302 ffd8d8a
update test
myrta2302 c834df0
update tests
myrta2302 5652e43
tests update
myrta2302 f3b5800
test update
myrta2302 d17f849
test updates
myrta2302 f6f5d71
Merge branch 'main' into 4651-review-prop-validation-across-component…
myrta2302 6e4acc4
revert card-control test
myrta2302 35dcf26
card control tests
myrta2302 00839c6
uncomment test
myrta2302 3f61906
Merge branch 'main' into 4651-review-prop-validation-across-component…
myrta2302 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@swisspost/design-system-documentation': patch | ||
'@swisspost/design-system-components': patch | ||
--- | ||
|
||
Aligned prop validation across the component library and replaced thrown errors with console errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
packages/components/cypress/fixtures/post-back-to-top.test.html
This file was deleted.
Oops, something went wrong.
myrta2302 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should probably not be deleted.