chore(apollo_l1_endpoint_monitor): extract RPC call to const and add tests #6336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
c04f4cb to
e6ff66d
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
e6ff66d to
2eb3373
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
f1a50b9 to
ea2621e
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
2eb3373 to
59ce563
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
59ce563 to
2cc96dc
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
2cc96dc to
532efcb
Compare
elintul
approved these changes
May 6, 2025
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.