chore(apollo_l1_endpoint_monitor): add client with minimal boilerplate #6329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
b6b1e56 to
80195c7
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
7595c68 to
1669365
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
80195c7 to
619bf7e
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
619bf7e to
91b4b80
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
1669365 to
f1a50b9
Compare
|
Benchmark movements: |
giladchase
changed the base branch from
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
to
graphite-base/6329
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
91b4b80 to
f52378a
Compare
giladchase
changed the base branch from
graphite-base/6329
to
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
f52378a to
fbb3102
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
branch
from
c04f4cb to
e6ff66d
Compare
giladchase
changed the base branch from
gilad/05-06-chore_apollo_l1_endpoint_monitor_extract_rpc_call_to_const_and_add_tests
to
graphite-base/6329
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
fbb3102 to
f200edc
Compare
giladchase
changed the base branch from
graphite-base/6329
to
gilad/05-06-chore_apollo_l1_endpoint_monitor_add_integration_test
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
f200edc to
123a599
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_add_integration_test
branch
from
04aeaeb to
5a27941
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
123a599 to
d8c1ec5
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_add_integration_test
branch
from
5a27941 to
645609e
Compare
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
d8c1ec5 to
d154da2
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_add_integration_test
branch
from
645609e to
c92792f
Compare
elintul
approved these changes
May 6, 2025
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_add_client_with_minimal_boilerplate
branch
from
d154da2 to
6917e83
Compare
giladchase
force-pushed
the
gilad/05-06-chore_apollo_l1_endpoint_monitor_add_integration_test
branch
from
c92792f to
5641b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.