chore(apollo_l1_endpoint_monitor): implement the core of l1 endpoint monitor #6328
+82
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
7595c68 to
1669365
Compare
|
Artifacts upload workflows: |
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
1669365 to
f1a50b9
Compare
elintul
approved these changes
May 6, 2025
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/apollo_l1_endpoint_monitor/src/monitor.rs line 8 at r1 (raw file):
type L1EndpointMonitorResult<T> = Result<T, L1EndpointMonitorError>; #[derive(Debug, Clone)]
Suggestion:
type L1EndpointMonitorResult<T> = Result<T, L1EndpointMonitorError>;
#[derive(Debug, Clone)]…monitor Constructors and other boilerplate stuff will come later.
giladchase
force-pushed
the
gilad/05-05-chore_apollo_l1_endpoint_monitor_implement_the_core_of_l1_endpoint_monitor
branch
from
f1a50b9 to
ea2621e
Compare
elintul
approved these changes
May 6, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors and other boilerplate stuff will come later.