Skip to content

Upgrade XamlX#42615

Open
sowelipililimute wants to merge 1 commit intospace-wizards:masterfrom
sowelipililimute:work/jblackquill/xamlx
Open

Upgrade XamlX#42615
sowelipililimute wants to merge 1 commit intospace-wizards:masterfrom
sowelipililimute:work/jblackquill/xamlx

Conversation

@sowelipililimute
Copy link
Member

@sowelipililimute sowelipililimute commented Jan 23, 2026

Requires space-wizards/RobustToolbox#6288

About the PR

Paying off our technical debt of being on a five-year-old XAML compiler.

Technical details

  • buttons are now styled by inheritance and not by a styleclass
  • the format for multiple style classes has changed

Requirements

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: UI Changes: Might require knowledge of UI design or code. size/M Denotes a PR that changes 100-999 lines. labels Jan 23, 2026
@sowelipililimute sowelipililimute mentioned this pull request Jan 23, 2026
Open
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@VerinSenpai VerinSenpai added A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 27, 2026
VerinSenpai
VerinSenpai reviewed Jan 27, 2026
View reviewed changes
Content.Client/CartridgeLoader/Cartridges/NanoTaskItemControl.xaml
<system:String>OpenLeft</system:String>
</Button.StyleClasses>
Text="{Loc 'nano-task-ui-done'}"
StyleClasses="ButtonSmall OpenLeft">
Copy link
Contributor

@VerinSenpai VerinSenpai Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? In my testing with the suicide window, it didn't.

Unless its part of the upgrade?

Copy link
Contributor

@VerinSenpai VerinSenpai Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read the engine PR, ignore me.

@VerinSenpai VerinSenpai added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005

1 more reviewer

@VerinSenpai VerinSenpai VerinSenpai left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sowelipililimute @VerinSenpai @PJBot