Open
Conversation
sowelipililimute
force-pushed
the
work/jblackquill/demo-xamlx
branch
2 times, most recently
from
94f916f to
e128d52
Compare
Member
Author
|
mostly working but xaml jit is broken on MethodAccessExceptions and i cannot figure out for the life of me what's going on there (needs content changes for how i reorganized the button styles) |
sowelipililimute
force-pushed
the
work/jblackquill/demo-xamlx
branch
from
0efc6dc to
b71f8b9
Compare
sowelipililimute
force-pushed
the
work/jblackquill/demo-xamlx
branch
from
b71f8b9 to
fd8a120
Compare
2 tasks
sowelipililimute
added
the
S: Requires Content PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires space-wizards/space-station-14#42615
This updates our XamlX to a newer version that lets us more easily support features such as templated controls and data binding without having to try and backport verifiable code fixes to our 5-year-old fork of XamlX.
Breaking Changes
Buttons have had their styling change to rely on inheritance from
PushButtonrather than a style class; this is because new behaviour wrt style classes is overriding instead of concatenative, and all uses of concatenation in content were for adding a single or more classes onto a button.Style classes also have a space-delimited syntax for multiple classes instead of the older verbose list notation.