Skip to content

Fix duplicate fallback controllers from the controller chain#3108

Open
saikishor wants to merge 1 commit intoros-controls:masterfrom
pal-robotics-forks:fix/duplicate/fallback_controllers
Open

Fix duplicate fallback controllers from the controller chain#3108
saikishor wants to merge 1 commit intoros-controls:masterfrom
pal-robotics-forks:fix/duplicate/fallback_controllers

Conversation

@saikishor
Copy link
Member

Fixes: #3038

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Mar 10, 2026
@Juliaj
Copy link
Contributor

Juliaj commented Mar 10, 2026

Fixes: #3038

Hi Sai, is there another issue that this PR fixes ? #3038 appears to be different from having duplicating fallback controllers. The scenario involves putting two (or more) controllers in the same chain group, each with a different fallback.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (2794132) to head (cc69288).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ontroller_manager/test/test_controller_manager.cpp 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
+ Coverage   89.27%   89.31%   +0.04%     
==========================================
  Files         158      158              
  Lines       19299    19359      +60     
  Branches     1560     1560              
==========================================
+ Hits        17229    17291      +62     
+ Misses       1425     1423       -2     
  Partials      645      645              
Flag Coverage Δ
unittests 89.31% <98.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 77.04% <100.00%> (ø)
...ontroller_manager/test/test_controller_manager.cpp 95.85% <98.33%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fallback controllers are collected from entire chain group, not just the failed controller

3 participants