[Spawner] Allow arguments per controller instead of global args (backport #2895)#3053
Open
mergify[bot] wants to merge 1 commit intokiltedfrom
Open
[Spawner] Allow arguments per controller instead of global args (backport #2895)#3053mergify[bot] wants to merge 1 commit intokiltedfrom
mergify[bot] wants to merge 1 commit intokiltedfrom
Conversation
(cherry picked from commit cb9a983)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## kilted #3053 +/- ##
==========================================
- Coverage 89.36% 89.25% -0.12%
==========================================
Files 157 158 +1
Lines 18792 19170 +378
Branches 1510 1549 +39
==========================================
+ Hits 16794 17110 +316
- Misses 1377 1424 +47
- Partials 621 636 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some changes to the Spawner to allow it to define the controller args per controller rather than global args for all the controllers.
I've added a new function in the launch_utils and I tested it using the following changes in example_12
https://github.com/ros-controls/ros2_control_demos/blob/advanced_spawner/example_12/bringup/launch/rrbot.launch.py
With this change we can do both the following
ros2 run controller_manager spawner ctrl_1 ctrl_2 --inactive --controller-ros-args ....and
ros2 run controller_manager spawner --controller ctrl_1 --load-only --controller ctrl_2 --inactive --controller-ros-args ...This is an automatic backport of pull request #2895 done by Mergify.