[VQueues] Share vqueues cache between scheduler and RSM#4699
Open
AhmedSoliman wants to merge 2 commits intomainfrom
Open
[VQueues] Share vqueues cache between scheduler and RSM#4699AhmedSoliman wants to merge 2 commits intomainfrom
AhmedSoliman wants to merge 2 commits intomainfrom
Conversation
This was referenced May 6, 2026
AhmedSoliman
force-pushed
the
pr4699
branch
2 times, most recently
from
7939141 to
4e45daa
Compare
Test Results 8 files + 1 8 suites +1 4m 47s ⏱️ + 2m 0s Results for commit da5e382. ± Comparison against base commit b128276. This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
AhmedSoliman
force-pushed
the
pr4699
branch
2 times, most recently
from
d8668b4 to
5f301d7
Compare
AhmedSoliman
commented
May 7, 2026
Comment on lines
67
to
+78
| @@ -75,7 +75,7 @@ where | |||
| OP_TYPE => self.kind.as_static_str(), | |||
| ) | |||
| .increment(1); | |||
| let span = tracing::Span::current().clone(); | |||
| let span = tracing::Span::current(); | |||
Contributor
Author
There was a problem hiding this comment.
Not related to this PR but happened to spot it.
AhmedSoliman
force-pushed
the
pr4699
branch
2 times, most recently
from
b1c1e11 to
4519cab
Compare
Replaces the single-head cache with a sorted 24-entry per-queue cache. Refills run via tokio::task::spawn_blocking when data isn't in the block cache; in-flight notify_enqueued / notify_removed events are buffered as an overlay (Add / Tombstone) and merged on completion. On overlay overflow we set a horizon (exclusive upper bound) instead of back-eviction: a popped tombstone could otherwise re-admit a deleted row. Storage rows at or above the horizon are dropped from the merge and rediscovered on the next refill. Drops the tailing iterator and its workarounds. Splits VQueueCursor into inbox (returns CursorError; WouldBlock under non-blocking opts) and VQueueRunningCursor (sync).
tillrohrmann
approved these changes
May 7, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Great work @AhmedSoliman. LGTM. +1 for merging :-)
| .eligible | ||
| .refresh_membership(event.queue, slot.meta(), qstate) | ||
| { | ||
| self.wake_up(); |
Contributor
There was a problem hiding this comment.
If we plan to no longer taskify the scheduler, should we also get rid of the self.wake_up calls? Or do they still have a purpose?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.