Skip to content

[VQueues] Share vqueues cache between scheduler and RSM #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmedSoliman merged 2 commits into from
May 8, 2026
Merged

[VQueues] Share vqueues cache between scheduler and RSM #4699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
672f6d2
[VQueues] Introducing inbox caching and read in batches
AhmedSoliman May 8, 2026
4f22aa6
[VQueues] Share vqueues cache between scheduler and RSM
AhmedSoliman May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions crates/partition-store/src/journal_table_v2/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,23 +769,23 @@ fn budgeted_journal_v2_stream<'a, DB: DBAccess + Send>(
impl WriteJournalTable for PartitionStoreTransaction<'_> {
fn put_journal_entry(
&mut self,
invocation_id: InvocationId,
invocation_id: &InvocationId,
index: u32,
entry: &StoredRawEntry,
related_completion_ids: &[CompletionId],
) -> Result<()> {
self.assert_partition_key(&invocation_id)?;
put_journal_entry(self, &invocation_id, index, entry, related_completion_ids)
self.assert_partition_key(invocation_id)?;
put_journal_entry(self, invocation_id, index, entry, related_completion_ids)
}

fn delete_journal(
&mut self,
invocation_id: InvocationId,
invocation_id: &InvocationId,
journal_length: EntryIndex,
) -> Result<()> {
self.assert_partition_key(&invocation_id)?;
self.assert_partition_key(invocation_id)?;
let _x = RocksDbPerfGuard::new("delete-journal");
delete_journal(self, &invocation_id, journal_length)
delete_journal(self, invocation_id, journal_length)
}
}

Expand Down
10 changes: 5 additions & 5 deletions crates/partition-store/src/tests/journal_table_v2_test/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ fn mock_one_way_call_command(invocation_id_completion_id: CompletionId) -> Entry
fn populate_sleep_journal<T: WriteJournalTable>(txn: &mut T) {
for i in 0..5 {
txn.put_journal_entry(
MOCK_INVOCATION_ID_1,
&MOCK_INVOCATION_ID_1,
i,
&StoredRawEntry::new(
StoredRawEntryHeader::new(MillisSinceEpoch::now()),
Expand All @@ -111,7 +111,7 @@ fn populate_sleep_journal<T: WriteJournalTable>(txn: &mut T) {
}
for i in 5..10 {
txn.put_journal_entry(
MOCK_INVOCATION_ID_1,
&MOCK_INVOCATION_ID_1,
i,
&StoredRawEntry::new(
StoredRawEntryHeader::new(MillisSinceEpoch::now()),
Expand Down Expand Up @@ -199,7 +199,7 @@ async fn sleep_point_lookups<T: ReadJournalTable>(txn: &mut T) {
}

fn delete_journal<T: WriteJournalTable>(txn: &mut T, length: usize) {
txn.delete_journal(MOCK_INVOCATION_ID_1, length as u32)
txn.delete_journal(&MOCK_INVOCATION_ID_1, length as u32)
.unwrap();
}

Expand Down Expand Up @@ -259,7 +259,7 @@ async fn test_call_journal() {

// Populate
txn.put_journal_entry(
MOCK_INVOCATION_ID_1,
&MOCK_INVOCATION_ID_1,
0,
&StoredRawEntry::new(
StoredRawEntryHeader::new(MillisSinceEpoch::now()),
Expand All @@ -269,7 +269,7 @@ async fn test_call_journal() {
)
.unwrap();
txn.put_journal_entry(
MOCK_INVOCATION_ID_1,
&MOCK_INVOCATION_ID_1,
1,
&StoredRawEntry::new(
StoredRawEntryHeader::new(MillisSinceEpoch::now()),
Expand Down
Loading
Loading