[VQueues] Commands for pause/resume in WAL protocol#4701
Draft
AhmedSoliman wants to merge 4 commits intomainfrom
Draft
[VQueues] Commands for pause/resume in WAL protocol#4701AhmedSoliman wants to merge 4 commits intomainfrom
AhmedSoliman wants to merge 4 commits intomainfrom
Conversation
This was referenced May 7, 2026
Replaces the single-head cache with a sorted 24-entry per-queue cache. Refills run via tokio::task::spawn_blocking when data isn't in the block cache; in-flight notify_enqueued / notify_removed events are buffered as an overlay (Add / Tombstone) and merged on completion. On overlay overflow we set a horizon (exclusive upper bound) instead of back-eviction: a popped tombstone could otherwise re-admit a deleted row. Storage rows at or above the horizon are dropped from the merge and rediscovered on the next refill. Drops the tailing iterator and its workarounds. Splits VQueueCursor into inbox (returns CursorError; WouldBlock under non-blocking opts) and VQueueRunningCursor (sync).
Expose vqueue entries as a single DataFusion table with stage-aware scanning. When the query filters `stage`, only matching stage key kinds are scanned; without a stage filter, all inbox stages are scanned and merged. Also project the latest entry metadata for observability (status plus EntryStatistics timestamps and counters), and add targeted tests for stage predicate extraction and sys_vqueues stage filtering behavior.
This implements the pause/resume commands for a batch of vqueue IDs in WAL protocol and the state machine. Note that this does not add any facility to initiate those commands. This will be done separately.
Test Results 8 files + 1 8 suites +1 4m 54s ⏱️ + 2m 7s Results for commit 8ea2cd1. ± Comparison against base commit b128276. This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the pause/resume commands for a batch of vqueue IDs in WAL protocol and the state machine. Note that this does not
add any facility to initiate those commands. This will be done separately.
Stack created with Sapling. Best reviewed with ReviewStack.