Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid the use of testing.T helpers #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Mar 3, 2025

Forbid the use of direct testing.T helpers in favor of testing toolkit like testify, To standardize this across all repos.

Updated repos:

@Sean-Der
Copy link
Member

Sean-Der commented Mar 4, 2025

@JoeTurki Lets do it! Want to split the repos, I can do half.

@JoeTurki
Copy link
Member Author

JoeTurki commented Mar 4, 2025

@Sean-Der I did a bit of work on pion/rtp, and was going to start making PRs tonight, let me start from the start of the list and if you wanna join from the end, and meet in the middle or depends on the pace we can go. what do you think :)

@JoeTurki
Copy link
Member Author

JoeTurki commented Mar 4, 2025

@Sean-Der the reason it didn't work is because we exclude forbidigo from test file, I made it so we only exclude it from examples, also we needed analyze-types option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants