Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint rules, use testify/assert #44

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

RyanPotat
Copy link
Member

Description

Update lint rules to forbid the use of direct testing.T helpers.

pion/.goassets#222

Reference issue

N/A

@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch from fc956d1 to 5ef5ffd Compare March 23, 2025 22:59
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (a16164d) to head (19bb927).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files           2        2           
  Lines          48       48           
=======================================
  Hits           38       38           
  Misses          7        7           
  Partials        3        3           
Flag Coverage Δ
go 79.16% <ø> (ø)
wasm 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanPotat RyanPotat force-pushed the RyanPotat/lint/test-helpers branch from 5ef5ffd to 19bb927 Compare March 23, 2025 23:01
@RyanPotat RyanPotat merged commit 19bb927 into master Mar 24, 2025
13 checks passed
@RyanPotat RyanPotat deleted the RyanPotat/lint/test-helpers branch March 24, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants