Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce testify/assert for tests #200

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Conversation

RyanPotat
Copy link
Member

Description

Use testify/assert in place of the standard testing package.

pion/.goassets#222

Reference issue

N/A

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.84%. Comparing base (c7c57e2) to head (b31edd8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   65.96%   65.84%   -0.13%     
==========================================
  Files          12       12              
  Lines        1660     1660              
==========================================
- Hits         1095     1093       -2     
- Misses        464      467       +3     
+ Partials      101      100       -1     
Flag Coverage Δ
go 65.84% <ø> (-0.13%) ⬇️
wasm 65.84% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Ryan, thank you for doing all of this.
(Just random nitpicks but I'm going to fix them myself while updating the lint file, no worries!)

@JoeTurki JoeTurki merged commit b31edd8 into pion:master Mar 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants