8339460: CDS error when module is located in a directory with space in the name

[TimPushkin]

Clean backport which fixes CDS's handling of paths that need to be escaped in path URLs.

Testing besides the CI (performed on macos/arm64): runtime/cds, a separate minimal reproducer app.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339460 needs maintainer approval

Issue

• JDK-8339460: CDS error when module is located in a directory with space in the name (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1833/head:pull/1833
$ git checkout pull/1833

Update a local copy of the PR:
$ git checkout pull/1833
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1833

View PR using the GUI difftool:
$ git pr show -t 1833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1833.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339460: CDS error when module is located in a directory with space in the name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• f2614cc: 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent
• 8e68eb1: 8340276: Test java/lang/management/ThreadMXBean/Locks.java failed with NullPointerException
• 773a2be: 8349378: Build splashscreen lib with SIZE optimization
• ... and 72 more: https://git.openjdk.org/jdk21u-dev/compare/286761666ba24988c9e19050efe9dae242335850...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @TimPushkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (4450885c)

[TimPushkin]

/approval request Clean backport that fixes path handling in CDS, e.g. without it having directories with spaces in names may lead to errors when dumping a static CDS archive. It also makes other planned backports cleaner.

Tests passed: tier1 (via GitHub CI), runtime/cds including one added test and a separate minimal reproducer app (locally on macos/arm64).

[openjdk]

@TimPushkin
8339460: The approval request has been created successfully.

[TimPushkin]

/integrate

[openjdk]

@TimPushkin
Your change (at version 4450885) is now ready to be sponsored by a Committer.